Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint": "next lint && biome lint --write --unsafe silently swallows errors #633

Open
inverted-capital opened this issue Dec 18, 2024 · 0 comments

Comments

@inverted-capital
Copy link

This command is acting like lint:fix in package.json.

It should be: lint": "next lint && biome lint, and the codebase should error each commit if it is not fully linted.

This is a problem since our linters all complain, so we run the fix, and then we have a stack of conflicts the next upstream commit we want to merge in.

I made a PR in #599 but I think it doesn't help to try merge in a linted version of the codebase, since that should be done by upstream ?

Do love the library tho, so thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant