Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal size wrong on startup #1790

Closed
m4r1vs opened this issue May 6, 2017 · 3 comments
Closed

terminal size wrong on startup #1790

m4r1vs opened this issue May 6, 2017 · 3 comments
Labels
👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself 🖼 Platform: Windows Issue pertains to Windows

Comments

@m4r1vs
Copy link

m4r1vs commented May 6, 2017

As you can see in this screenshot the Terminal size is not correct on startup. When I nano or vim something its adjusted right.
image
I'm using bash for windows with oh my zsh.

  • OS version and name: Windows 10 build 15063
  • Hyper.app version: 1.3.1
  • Link of a Gist with the contents of your .hyper.js: Looks worse with "hyperfull" plugin, but is also reproducible without.
  • Relevant information from devtools: no
  • The issue is reproducible in vanilla Hyper.app: yes
@renzo1974
Copy link

renzo1974 commented May 15, 2017

I have a similar behaviour. When I resize my WSL session in Hyper to a width of at least 160chars, the following will happen:

  • On every line feed with a command the cursor is moved some chars to the right (the length of the given command).
  • The first chars are displayed at the end of the line before

At the screenshot you see that the path is splitted and the cursor is wrong positioned.
2017-05-15 10_20_34-hyper

  • OS Version: Windows 10 - 1703
  • Hyper 1.3.3
  • Original .hyper.js

Update:
The same problem exists in integrated Terminal of "VisualStudio Code" Editor.

@MartyGentillon
Copy link
Contributor

MartyGentillon commented May 17, 2017

So, the second issue that you are suffering @rm-jamotion is a regression windows itself and how the windows terminal is handling multibyte characters in the most recent update, and affects multiple terminal emulators. (see microsoft/vscode#19665; rprichard/winpty#105 for more details) Apparently, this will be fixed with the next windows update later this year.

@albinekb albinekb added 👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself 🖼 Platform: Windows Issue pertains to Windows labels May 26, 2017
@ppot
Copy link
Contributor

ppot commented Aug 15, 2017

Based on microsoft/vscode#19665 I will mark this as fixed.

@ppot ppot closed this as completed Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👆 Is Upstream Issue is the fault of something Hyper uses and not Hyper itself 🖼 Platform: Windows Issue pertains to Windows
Projects
None yet
Development

No branches or pull requests

5 participants