Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default startup directory #4200

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Conversation

LabhanshAgrawal
Copy link
Collaborator

Fixes #4197

The bug was introduced in #3769 , which probably went unnoticed because on mac and linux default config dir is home.

@ppot
Copy link
Contributor

ppot commented Jan 25, 2020

Honestly, can you rework this workingDirectory thing ? I know you where not the one who made the original, but homeDirectory was change for cfgDirg and also, this should be a plugin thing.
Also, this should be a profileDirectory but since mostly not everyone will use it, it's just noice.

The comment // set custom startup directory (must be an absolute path) should say instead
// set profile directory for default startup (must be an absolute path)

@Stanzilla
Copy link
Contributor

Could be done in a follow up PR, imo. Merging this now to get the fix in

@Stanzilla Stanzilla merged commit 0d08691 into vercel:canary Jan 27, 2020
@LabhanshAgrawal LabhanshAgrawal deleted the workingDir branch January 27, 2020 18:55
@LabhanshAgrawal
Copy link
Collaborator Author

@ppot can you elaborate a bit, not sure if I understand your comment fully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default startup directory changed in latest canary build
3 participants