Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<Image /> accepts the style property even though it is ignored #18793

Closed
Timer opened this issue Nov 4, 2020 · 1 comment · Fixed by #18796
Closed

<Image /> accepts the style property even though it is ignored #18793

Timer opened this issue Nov 4, 2020 · 1 comment · Fixed by #18796
Assignees
@Timer
Milestone
iteration 12

Comments

@Timer
Copy link
Member

Timer commented Nov 4, 2020

Bug report

Describe the bug

<Image /> accepts the style property even though it is ignored.

To Reproduce

In a TypeScript file, try to build the following code:

<Image layout='fill' src='...' style={{}} />

Expected behavior

A TypeScript error should occur.
@Timer Timer added the kind: bug label Nov 4, 2020
@Timer Timer self-assigned this Nov 4, 2020
@Timer Timer added the point: 2 label Nov 4, 2020
@Timer Timer added this to the iteration 12 milestone Nov 4, 2020
Timer added a commit to Timer/next.js that referenced this issue Nov 4, 2020
@Timer
Omit ignored property from <Image/ > to prevent confusion
12f57f8 
Fixes vercel#18793
@Timer Timer mentioned this issue Nov 4, 2020
Merged
@Timer Timer added point: 1 and removed point: 2 labels Nov 4, 2020
@kodiakhq kodiakhq bot closed this as completed in #18796 Nov 4, 2020
kodiakhq bot pushed a commit that referenced this issue Nov 4, 2020
@Timer
Omit ignored property from <Image/ > to prevent confusion (#18796)
bb8a49e 
Fixes #18793
jamesgeorge007 pushed a commit to jamesgeorge007/next.js that referenced this issue Nov 5, 2020
@Timer @jamesgeorge007
Omit ignored property from <Image/ > to prevent confusion (vercel#18796)
af4c3bd 
Fixes vercel#18793
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Timer Timer

Labels
None yet
Projects
None yet
Milestone
iteration 12
Development

Successfully merging a pull request may close this issue.

Omit ignored property from <Image/ > to prevent confusion Timer/next.js
2 participants
@Timer @balazsorban44