Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use absolute paths #21877

Merged
merged 4 commits into from
Feb 16, 2021
Merged

fix: use absolute paths #21877

merged 4 commits into from
Feb 16, 2021

Conversation

merceyz
Copy link
Contributor

@merceyz merceyz commented Feb 4, 2021 •
edited
Loading

What's the problem this PR addresses?

The hook added in #21802 doesn't use absolute paths so it doesn't work correctly

How did you fix it?

Use absolute paths

@merceyz merceyz force-pushed the merceyz/webpack-hook branch 3 times, most recently from 7a57437 to 6567cfc Compare February 4, 2021 21:01
@ijjk
Copy link
Member

ijjk commented Feb 4, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 8.9s 8.8s -166ms
nodeModulesSize 75.3 MB 75.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.73 1.759 ⚠️ +0.03
/ avg req/sec 1445.14 1421.24 ⚠️ -23.9
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.126 1.105 -0.02
/error-in-render avg req/sec 2219.97 2262.47 +42.5
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 10.5s 10.8s ⚠️ +276ms
nodeModulesSize 75.3 MB 75.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 10.6s 10.8s ⚠️ +212ms
nodeModulesSize 75.3 MB 75.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.769 1.763 -0.01
/ avg req/sec 1412.91 1417.67 +4.76
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.09 1.083 -0.01
/error-in-render avg req/sec 2293.1 2308.06 +14.96
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
597-6c246419..806f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.9 kB 59.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "yWJClqOds7_RUOUqAgkCh",
+        "buildId": "tyHt7TpVwEj1nMJFU8icP",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/yWJClqOds7_RUOUqAgkCh/_buildManifest.js"
+      src="/_next/static/tyHt7TpVwEj1nMJFU8icP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/yWJClqOds7_RUOUqAgkCh/_ssgManifest.js"
+      src="/_next/static/tyHt7TpVwEj1nMJFU8icP/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "yWJClqOds7_RUOUqAgkCh",
+        "buildId": "tyHt7TpVwEj1nMJFU8icP",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/yWJClqOds7_RUOUqAgkCh/_buildManifest.js"
+      src="/_next/static/tyHt7TpVwEj1nMJFU8icP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/yWJClqOds7_RUOUqAgkCh/_ssgManifest.js"
+      src="/_next/static/tyHt7TpVwEj1nMJFU8icP/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "yWJClqOds7_RUOUqAgkCh",
+        "buildId": "tyHt7TpVwEj1nMJFU8icP",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/yWJClqOds7_RUOUqAgkCh/_buildManifest.js"
+      src="/_next/static/tyHt7TpVwEj1nMJFU8icP/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/yWJClqOds7_RUOUqAgkCh/_ssgManifest.js"
+      src="/_next/static/tyHt7TpVwEj1nMJFU8icP/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 7a57437

@ijjk
Copy link
Member

ijjk commented Feb 4, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 9s 8.9s -98ms
nodeModulesSize 75.3 MB 75.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.767 1.781 ⚠️ +0.01
/ avg req/sec 1414.96 1403.99 ⚠️ -10.97
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.119 1.069 -0.05
/error-in-render avg req/sec 2234.88 2337.58 +102.7
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 10.8s 10.8s -57ms
nodeModulesSize 75.3 MB 75.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 10.7s 10.9s ⚠️ +186ms
nodeModulesSize 75.3 MB 75.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.78 1.755 -0.03
/ avg req/sec 1404.27 1424.64 +20.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.109 1.151 ⚠️ +0.04
/error-in-render avg req/sec 2255.1 2172.59 ⚠️ -82.51
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
597-6c246419..806f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.9 kB 59.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "9vhE_VY-tXRRwMSZNYndD",
+        "buildId": "_XheALXnYPxfqAhgE0KkF",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/9vhE_VY-tXRRwMSZNYndD/_buildManifest.js"
+      src="/_next/static/_XheALXnYPxfqAhgE0KkF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/9vhE_VY-tXRRwMSZNYndD/_ssgManifest.js"
+      src="/_next/static/_XheALXnYPxfqAhgE0KkF/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "9vhE_VY-tXRRwMSZNYndD",
+        "buildId": "_XheALXnYPxfqAhgE0KkF",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/9vhE_VY-tXRRwMSZNYndD/_buildManifest.js"
+      src="/_next/static/_XheALXnYPxfqAhgE0KkF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/9vhE_VY-tXRRwMSZNYndD/_ssgManifest.js"
+      src="/_next/static/_XheALXnYPxfqAhgE0KkF/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "9vhE_VY-tXRRwMSZNYndD",
+        "buildId": "_XheALXnYPxfqAhgE0KkF",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/9vhE_VY-tXRRwMSZNYndD/_buildManifest.js"
+      src="/_next/static/_XheALXnYPxfqAhgE0KkF/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/9vhE_VY-tXRRwMSZNYndD/_ssgManifest.js"
+      src="/_next/static/_XheALXnYPxfqAhgE0KkF/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 6567cfc

@merceyz merceyz force-pushed the merceyz/webpack-hook branch from 6567cfc to 262fa3c Compare February 4, 2021 21:11
@ijjk
Copy link
Member

ijjk commented Feb 4, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 10.3s 10.2s -113ms
nodeModulesSize 75.3 MB 75.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.066 2.195 ⚠️ +0.13
/ avg req/sec 1210.02 1139.11 ⚠️ -70.91
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.437 1.515 ⚠️ +0.08
/error-in-render avg req/sec 1739.72 1650.43 ⚠️ -89.29
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 12.1s 12s -21ms
nodeModulesSize 75.3 MB 75.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 12.5s 13.2s ⚠️ +714ms
nodeModulesSize 75.3 MB 75.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.17 2.05 -0.12
/ avg req/sec 1151.87 1219.68 +67.81
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.522 1.432 -0.09
/error-in-render avg req/sec 1642.63 1746.29 +103.66
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
597-6c246419..806f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.9 kB 59.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "fGk_Z3T9MCXZTdCz2dWJP",
+        "buildId": "xzLVJBYLMdIjO7-DEalJ8",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/fGk_Z3T9MCXZTdCz2dWJP/_buildManifest.js"
+      src="/_next/static/xzLVJBYLMdIjO7-DEalJ8/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/fGk_Z3T9MCXZTdCz2dWJP/_ssgManifest.js"
+      src="/_next/static/xzLVJBYLMdIjO7-DEalJ8/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "fGk_Z3T9MCXZTdCz2dWJP",
+        "buildId": "xzLVJBYLMdIjO7-DEalJ8",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/fGk_Z3T9MCXZTdCz2dWJP/_buildManifest.js"
+      src="/_next/static/xzLVJBYLMdIjO7-DEalJ8/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/fGk_Z3T9MCXZTdCz2dWJP/_ssgManifest.js"
+      src="/_next/static/xzLVJBYLMdIjO7-DEalJ8/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "fGk_Z3T9MCXZTdCz2dWJP",
+        "buildId": "xzLVJBYLMdIjO7-DEalJ8",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/fGk_Z3T9MCXZTdCz2dWJP/_buildManifest.js"
+      src="/_next/static/xzLVJBYLMdIjO7-DEalJ8/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/fGk_Z3T9MCXZTdCz2dWJP/_ssgManifest.js"
+      src="/_next/static/xzLVJBYLMdIjO7-DEalJ8/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 262fa3c

@merceyz merceyz force-pushed the merceyz/webpack-hook branch from 262fa3c to 755ee79 Compare February 4, 2021 22:21
@merceyz merceyz mentioned this pull request Feb 4, 2021
Merged
@ijjk
Copy link
Member

ijjk commented Feb 4, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 10.8s 11.1s ⚠️ +313ms
nodeModulesSize 75.3 MB 75.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.177 2.216 ⚠️ +0.04
/ avg req/sec 1148.47 1128.23 ⚠️ -20.24
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.426 1.403 -0.02
/error-in-render avg req/sec 1753.75 1782.06 +28.31
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 12.9s 12.8s -42ms
nodeModulesSize 75.3 MB 75.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 13.2s 13.1s -116ms
nodeModulesSize 75.3 MB 75.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.175 2.126 -0.05
/ avg req/sec 1149.18 1175.9 +26.72
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.279 1.399 ⚠️ +0.12
/error-in-render avg req/sec 1954.89 1786.51 ⚠️ -168.38
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
597-6c246419..806f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.9 kB 59.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "TmP-fgw5E_E4xvWANPVdv",
+        "buildId": "HKkDwnCcYAIOEd_QkDYZk",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/TmP-fgw5E_E4xvWANPVdv/_buildManifest.js"
+      src="/_next/static/HKkDwnCcYAIOEd_QkDYZk/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/TmP-fgw5E_E4xvWANPVdv/_ssgManifest.js"
+      src="/_next/static/HKkDwnCcYAIOEd_QkDYZk/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "TmP-fgw5E_E4xvWANPVdv",
+        "buildId": "HKkDwnCcYAIOEd_QkDYZk",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/TmP-fgw5E_E4xvWANPVdv/_buildManifest.js"
+      src="/_next/static/HKkDwnCcYAIOEd_QkDYZk/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/TmP-fgw5E_E4xvWANPVdv/_ssgManifest.js"
+      src="/_next/static/HKkDwnCcYAIOEd_QkDYZk/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "TmP-fgw5E_E4xvWANPVdv",
+        "buildId": "HKkDwnCcYAIOEd_QkDYZk",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/TmP-fgw5E_E4xvWANPVdv/_buildManifest.js"
+      src="/_next/static/HKkDwnCcYAIOEd_QkDYZk/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/TmP-fgw5E_E4xvWANPVdv/_ssgManifest.js"
+      src="/_next/static/HKkDwnCcYAIOEd_QkDYZk/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 755ee79

@ijjk ijjk added the type: next label Feb 4, 2021
@merceyz merceyz changed the title ci: add PnP test for webpack require hook fix: register webpack hook earlier and use absolute paths Feb 4, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Feb 4, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 10.4s 9.6s -831ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +338 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.164 2.314 ⚠️ +0.15
/ avg req/sec 1155.33 1080.34 ⚠️ -74.99
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.452 1.47 ⚠️ +0.02
/error-in-render avg req/sec 1721.52 1700.28 ⚠️ -21.24
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 12s 12s ⚠️ +57ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +338 B
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 12.8s 14.4s ⚠️ +1.7s
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +338 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.132 2.297 ⚠️ +0.17
/ avg req/sec 1172.53 1088.32 ⚠️ -84.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.493 1.579 ⚠️ +0.09
/error-in-render avg req/sec 1674.49 1583.24 ⚠️ -91.25
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
597-6c246419..806f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.9 kB 59.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "AI9N_qw-U361sc3MSB5na",
+        "buildId": "Hl8bETal6BLB2EtqnET-Y",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/AI9N_qw-U361sc3MSB5na/_buildManifest.js"
+      src="/_next/static/Hl8bETal6BLB2EtqnET-Y/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/AI9N_qw-U361sc3MSB5na/_ssgManifest.js"
+      src="/_next/static/Hl8bETal6BLB2EtqnET-Y/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "AI9N_qw-U361sc3MSB5na",
+        "buildId": "Hl8bETal6BLB2EtqnET-Y",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/AI9N_qw-U361sc3MSB5na/_buildManifest.js"
+      src="/_next/static/Hl8bETal6BLB2EtqnET-Y/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/AI9N_qw-U361sc3MSB5na/_ssgManifest.js"
+      src="/_next/static/Hl8bETal6BLB2EtqnET-Y/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "AI9N_qw-U361sc3MSB5na",
+        "buildId": "Hl8bETal6BLB2EtqnET-Y",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/AI9N_qw-U361sc3MSB5na/_buildManifest.js"
+      src="/_next/static/Hl8bETal6BLB2EtqnET-Y/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/AI9N_qw-U361sc3MSB5na/_ssgManifest.js"
+      src="/_next/static/Hl8bETal6BLB2EtqnET-Y/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 2a07c75

@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Feb 4, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 10.8s 10.6s -108ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +683 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.208 2.191 -0.02
/ avg req/sec 1132.33 1141.02 +8.69
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.563 1.592 ⚠️ +0.03
/error-in-render avg req/sec 1599.24 1570.34 ⚠️ -28.9
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
index.html gzip 615 B 615 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 12.4s 12.6s ⚠️ +111ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +683 B
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 13.2s 13.3s ⚠️ +139ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +683 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.236 2.289 ⚠️ +0.05
/ avg req/sec 1117.86 1092.4 ⚠️ -25.46
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.634 1.61 -0.02
/error-in-render avg req/sec 1530.02 1553.15 +23.13
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
597-6c246419..806f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.9 kB 59.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 580 B 580 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "xveaJAGGG1y6O8NjqYiS6",
+        "buildId": "T6wsprK53EqcAedUfSisf",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/xveaJAGGG1y6O8NjqYiS6/_buildManifest.js"
+      src="/_next/static/T6wsprK53EqcAedUfSisf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/xveaJAGGG1y6O8NjqYiS6/_ssgManifest.js"
+      src="/_next/static/T6wsprK53EqcAedUfSisf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "xveaJAGGG1y6O8NjqYiS6",
+        "buildId": "T6wsprK53EqcAedUfSisf",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/xveaJAGGG1y6O8NjqYiS6/_buildManifest.js"
+      src="/_next/static/T6wsprK53EqcAedUfSisf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/xveaJAGGG1y6O8NjqYiS6/_ssgManifest.js"
+      src="/_next/static/T6wsprK53EqcAedUfSisf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "xveaJAGGG1y6O8NjqYiS6",
+        "buildId": "T6wsprK53EqcAedUfSisf",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/xveaJAGGG1y6O8NjqYiS6/_buildManifest.js"
+      src="/_next/static/T6wsprK53EqcAedUfSisf/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/xveaJAGGG1y6O8NjqYiS6/_ssgManifest.js"
+      src="/_next/static/T6wsprK53EqcAedUfSisf/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 429f2de

guybedford
guybedford previously approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for following up on this.

@merceyz
Copy link
Contributor Author

merceyz commented Feb 5, 2021

I'm not sure what to do about all those failing tests though, so if someone wants to take a look at that I would appreciate it

guybedford
guybedford reviewed Feb 5, 2021
View reviewed changes
test-pnp.sh
@@ -1,4 +1,7 @@
declare -a testCases=(
# Tests the webpack require hook
"progressive-web-app"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the failures due to this addition? Can we at least test that.

Copy link
Contributor Author

@merceyz merceyz Feb 5, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't affect the Build, test, and deploy / Test Integration (5) (pull_request) family of tests

@ijjk
Copy link
Member

ijjk commented Feb 9, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 11.1s 10.9s -228ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +345 B
Page Load Tests Overall increase ✓
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.334 2.306 -0.03
/ avg req/sec 1071.14 1083.92 +12.78
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.647 1.603 -0.04
/error-in-render avg req/sec 1517.7 1559.83 +42.13
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
index.html gzip 615 B 615 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 13.2s 13s -142ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +345 B
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
677f882d2ed8..49c4.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.5 kB 59.5 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
buildDuration 13.3s 13.5s ⚠️ +192ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +345 B
Page Load Tests Overall increase ✓
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.228 2.222 -0.01
/ avg req/sec 1122.29 1125.03 +2.74
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.567 1.563 0
/error-in-render avg req/sec 1595.68 1599.95 +4.27
Client Bundles (main, webpack, commons)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
597-6c246419..806f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.9 kB 59.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB ✓
_error-7a100..a392.js gzip 3.38 kB 3.38 kB ✓
hooks-f7e199..11b9.js gzip 904 B 904 B ✓
index-3dc22c..ffbb.js gzip 232 B 232 B ✓
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB ✓
routerDirect..323a.js gzip 308 B 308 B ✓
withRouter-a..2ef8.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary merceyz/next.js merceyz/webpack-hook Change
index.html gzip 584 B 584 B ✓
link.html gzip 591 B 591 B ✓
withRouter.html gzip 578 B 578 B ✓
Overall change 1.75 kB 1.75 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "avcJsqAOxpXF6YmjcZQwc",
+        "buildId": "gLEXtZ22dYZc6bnSMm4ZT",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/avcJsqAOxpXF6YmjcZQwc/_buildManifest.js"
+      src="/_next/static/gLEXtZ22dYZc6bnSMm4ZT/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/avcJsqAOxpXF6YmjcZQwc/_ssgManifest.js"
+      src="/_next/static/gLEXtZ22dYZc6bnSMm4ZT/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "avcJsqAOxpXF6YmjcZQwc",
+        "buildId": "gLEXtZ22dYZc6bnSMm4ZT",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/avcJsqAOxpXF6YmjcZQwc/_buildManifest.js"
+      src="/_next/static/gLEXtZ22dYZc6bnSMm4ZT/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/avcJsqAOxpXF6YmjcZQwc/_ssgManifest.js"
+      src="/_next/static/gLEXtZ22dYZc6bnSMm4ZT/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "avcJsqAOxpXF6YmjcZQwc",
+        "buildId": "gLEXtZ22dYZc6bnSMm4ZT",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/avcJsqAOxpXF6YmjcZQwc/_buildManifest.js"
+      src="/_next/static/gLEXtZ22dYZc6bnSMm4ZT/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/avcJsqAOxpXF6YmjcZQwc/_ssgManifest.js"
+      src="/_next/static/gLEXtZ22dYZc6bnSMm4ZT/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: e849c56

@timneutkens timneutkens marked this pull request as ready for review February 16, 2021 08:46
This was referenced Mar 8, 2021
Closed
Merged
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
This was referenced Mar 15, 2021
Closed
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guybedford guybedford guybedford left review comments

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@merceyz @ijjk @timneutkens @guybedford