-
Notifications
You must be signed in to change notification settings - Fork 27.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Router clears Options in the window.history.state #8634
Comments
pavelzubov
added a commit
to pavelzubov/next.js
that referenced
this issue
Sep 16, 2019
Set history options if window.history.state is defined
Closed
Re-opened #771 because as of right now manipulating |
This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Bug report
Describe the bug
It seems that next-server router clears Options object from the window.history.state.
To Reproduce
Expected behavior
Router recreate Options in the window.history.state
Additional context
I've investigated that problem has its roots in the Router constructor
https://github.com/zeit/next.js/blob/canary/packages/next/next-server/lib/router/router.ts#L129
It calls method this.changeState(...) without passing Options object. And default value for Options is empty object {}.
The text was updated successfully, but these errors were encountered: