Incorrect TS type of AppTree?

[fwojciec]

Bug report

Describe the bug

Currently the TS type for AppTree component is AppType:

export declare type AppType = NextComponentType<AppContextType, AppInitialProps, AppPropsType>

(...)

export interface NextPageContext {
    // (...)
    AppTree: AppType;
}

This seems incorrect, since this type defines Component and router as required props. As a result, it is impossible to use AppTree in getInitialProps of a page component without manually overriding the type, since there is no way to access Component and router from NextPageContext. AppTree appears to work just fine without the props defined as required -- and in fact the official with-apollo example uses AppTree in precisely this way.

To Reproduce

1. Reproduction repo here: https://github.com/fwojciec/apptree-type-reproduction-example
2. The relevant file is lib/apollo.tsx
3. I'm overriding the types for AppTree in this HOC (very loosely based on the official with-apollo example) in order to make it work in TypeScript (see FixedAppTree).
4. If you replace FixedAppTree with the original AppTree on line 56 the TS compiler will complain about missing props:

Type '{ pageProps: { apolloClient: ApolloClient<NormalizedCacheObject>; }; }' is missing the following properties from type '{ Component: NextComponentType<NextPageContext, any, {}>; router: NextRouter; }': Component, routerts(2739)

Expected behavior

The default type of AppTree should not define Component and router as required props.

System information

• OS: macOS
• Browser: N/A
• Version of Next.js: 9.0.5

Additional context

• TypeScript version: 3.6.2

[fwojciec]

Created a pull request to fix this -- though I'm not sure this is the best approach:
#8662

[balazsorban44]

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.