Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit ignored property from <Image/ > to prevent confusion #18796

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Omit ignored property from <Image/ > to prevent confusion #18796

merged 1 commit into from
Nov 4, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Nov 4, 2020

Fixes #18793

@Timer Timer requested a review from styfle November 4, 2020 15:50
@ijjk ijjk added the type: next label Nov 4, 2020
@styfle styfle mentioned this pull request Nov 4, 2020
Closed
styfle
styfle approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Nov 4, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/image-type Change
buildDuration 13.1s 13.1s ⚠️ +60ms
nodeModulesSize 90.5 MB 90.5 MB ⚠️ +20 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/image-type Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.409 2.399 -0.01
/ avg req/sec 1037.65 1042.11 +4.46
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.279 1.25 -0.03
/error-in-render avg req/sec 1954.68 2000.52 +45.84
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/image-type Change
677f882d2ed8..1f3c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-be398bc..d262.js gzip 7.33 kB 7.33 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/image-type Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-378f0c6..dule.js gzip 6.33 kB 6.33 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/image-type Change
polyfills-b5..1119.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/image-type Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/image-type Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/image-type Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/image-type Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 994 B 994 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/image-type Change
buildDuration 14.8s 15.2s ⚠️ +399ms
nodeModulesSize 90.5 MB 90.5 MB ⚠️ +20 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/image-type Change
677f882d2ed8..1f3c.js gzip 11.2 kB 11.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-be398bc..d262.js gzip 7.33 kB 7.33 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58.3 kB 58.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js hotfix/image-type Change
677f882d2ed8..dule.js gzip 7.02 kB 7.02 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-378f0c6..dule.js gzip 6.33 kB 6.33 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 53.1 kB 53.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/image-type Change
polyfills-b5..1119.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/image-type Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-a674d88..ccde.js gzip 1.35 kB 1.35 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.75 kB 7.75 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/image-type Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-a4469f3..dule.js gzip 1.32 kB 1.32 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.41 kB 5.41 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/image-type Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/image-type Change
_error.js 1.07 MB 1.07 MB ✓
404.html 4.73 kB 4.73 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.07 MB 1.07 MB ✓
link.js 1.12 MB 1.12 MB ✓
routerDirect.js 1.11 MB 1.11 MB ✓
withRouter.js 1.11 MB 1.11 MB ✓
Overall change 5.48 MB 5.48 MB ✓
Commit: 12f57f8

@kodiakhq kodiakhq bot merged commit bb8a49e into vercel:canary Nov 4, 2020
jamesgeorge007 pushed a commit to jamesgeorge007/next.js that referenced this pull request Nov 5, 2020
@Timer @jamesgeorge007
Omit ignored property from <Image/ > to prevent confusion (vercel#18796)
af4c3bd 
Fixes vercel#18793
@Timer Timer deleted the hotfix/image-type branch November 6, 2020 04:23
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<Image /> accepts the style property even though it is ignored
4 participants
@Timer @ijjk @styfle @timneutkens