From e566e6662ecae408f50a0bd38d77ce397e88031b Mon Sep 17 00:00:00 2001 From: Jiachi Liu Date: Tue, 9 Nov 2021 20:23:38 +0100 Subject: [PATCH 1/2] test: skip flaky dynamic import tests --- .../test/index.test.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/integration/react-streaming-and-server-components/test/index.test.js b/test/integration/react-streaming-and-server-components/test/index.test.js index 4a6ca0119a0ac..a5c2df29296b9 100644 --- a/test/integration/react-streaming-and-server-components/test/index.test.js +++ b/test/integration/react-streaming-and-server-components/test/index.test.js @@ -143,7 +143,8 @@ describe('concurrentFeatures - prod', () => { expect(content.clientInfo).not.toContainEqual([['/404', true]]) }) - it('should support React.lazy and dynamic imports', async () => { + // TODO: re-enabled test when update webpack with chunkLoading support + it.skip('should support React.lazy and dynamic imports', async () => { const html = await renderViaHTTP(context.appPort, '/dynamic-imports') expect(html).toContain('foo.client') }) @@ -162,7 +163,8 @@ describe('concurrentFeatures - dev', () => { await killApp(context.server) }) - it('should support React.lazy and dynamic imports', async () => { + // TODO: re-enabled test when update webpack with chunkLoading support + it.skip('should support React.lazy and dynamic imports', async () => { const html = await renderViaHTTP(context.appPort, '/dynamic-imports') expect(html).toContain('loading...') From ef67f5b11f2c580858fc21a961aa9628fbac303e Mon Sep 17 00:00:00 2001 From: Jiachi Liu Date: Tue, 9 Nov 2021 20:43:49 +0100 Subject: [PATCH 2/2] keep stable one --- .../react-streaming-and-server-components/test/index.test.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/integration/react-streaming-and-server-components/test/index.test.js b/test/integration/react-streaming-and-server-components/test/index.test.js index a5c2df29296b9..5de5fae9637e0 100644 --- a/test/integration/react-streaming-and-server-components/test/index.test.js +++ b/test/integration/react-streaming-and-server-components/test/index.test.js @@ -143,8 +143,7 @@ describe('concurrentFeatures - prod', () => { expect(content.clientInfo).not.toContainEqual([['/404', true]]) }) - // TODO: re-enabled test when update webpack with chunkLoading support - it.skip('should support React.lazy and dynamic imports', async () => { + it('should support React.lazy and dynamic imports', async () => { const html = await renderViaHTTP(context.appPort, '/dynamic-imports') expect(html).toContain('foo.client') })