Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[turborepo] pipeline.build.inputs globbing not working #3467

Closed
revero-doug opened this issue Jan 25, 2023 · 2 comments · May be fixed by X-oss-byte/turbo#137
Closed

[turborepo] pipeline.build.inputs globbing not working #3467

revero-doug opened this issue Jan 25, 2023 · 2 comments · May be fixed by X-oss-byte/turbo#137
Labels
kind: bug Something isn't working needs: author input

Comments

@revero-doug
Copy link

What version of Turborepo are you using?

^1.6.3

What package manager are you using / does the bug impact?

pnpm

What operating system are you using?

Mac

Describe the Bug

none of the following values for pipeline.build.inputs work to include all files under ./src (relative to a package in the monorepo) when running in a docker build context that does not include the .git directory with remote caching (via fox1t/turborepo-remote-cache); as a result, there are cache hits when there should be misses.

  • src
  • src/**
  • src/**/*

caching works as expected when leaving pipeline.build.inputs undefined

Expected Behavior

the cache is invalidated when any files specified by a globbing pattern in the pipeline.build.inputs array, change

To Reproduce

run pnpm turbo build in a Dockerfile with remote caching against a container running fox1t/turborepo-remote-cache, with the monorepo .git directory excluded from the build context by adding to .dockerignore

Reproduction Repo

No response

@revero-doug revero-doug added area: turborepo kind: bug Something isn't working labels Jan 25, 2023
@chris-olszewski
Copy link
Member

Could you provide a reproduction? This sounds like a configuration which will be hard to identify without looking at how your repo is setup.

@anthonyshew
Copy link
Contributor

Closing as stale with no reproduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working needs: author input
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants