Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of comma separator #1186

Merged
merged 2 commits into from
Jan 14, 2019
Merged

Remove use of comma separator #1186

merged 2 commits into from
Jan 14, 2019

Conversation

DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented Jan 14, 2019

Type:
bug

The following has been addressed in the PR:

  • There is a related issue?
  • Unit or Functional tests are included in the PR

Description:
The comma operator takes two expressions, executes them from left to right and returns the result of the second one. Use of this operator is generally detrimental to the readability and reliability of code, and the same effect can be achieved by other means.

Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the uncle Bob says, clean code. Thanks 👍

@juanpicado juanpicado merged commit f20fefa into verdaccio:master Jan 14, 2019
@DanielRuf DanielRuf deleted the fix/remove-comma-separator branch March 17, 2019 19:20
@lock
Copy link

lock bot commented Jun 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants