Update conda_mirror.py #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an optional command line parameter to choose the temporary download location for applying the checks before moving the packages to the target location, which was hardcoded to the default temporary directory before. Now this is the default location, when not explicitly specifying the temp_directory parameter.
Current coverage is 92.48% (diff: 100%)@@ master #21 diff @@
==========================================
Files 2 2
Lines 212 213 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 196 197 +1
Misses 16 16
Partials 0 0
|
|
LGTM. Thanks @jneines . I'll cut a new release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional command line parameter to choose the temporary download location for applying the checks before moving the packages to the target location, which was hardcoded to the default temporary directory before. Now this is the default location, when not explicitly specifying the temp_directory parameter.
This should fix issue #19