From c94670eea7c92dce933c4f932a9c8baf4a62fcfc Mon Sep 17 00:00:00 2001 From: David Robertson Date: Thu, 19 Oct 2023 18:58:17 +0100 Subject: [PATCH] Prevent a test from writing to a closed v2 server --- tests-integration/connection_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests-integration/connection_test.go b/tests-integration/connection_test.go index a0ab7ae1..d1143a2e 100644 --- a/tests-integration/connection_test.go +++ b/tests-integration/connection_test.go @@ -253,6 +253,7 @@ func TestConnectionTimeoutNotReset(t *testing.T) { } req.SetTimeoutMSecs(1000) // 1s // inject 4 events 500ms apart - if we reset the timeout each time then we will return late + done := make(chan struct{}) go func() { time.Sleep(10 * time.Millisecond) ticker := time.NewTicker(500 * time.Millisecond) @@ -277,6 +278,7 @@ func TestConnectionTimeoutNotReset(t *testing.T) { }) i++ } + done <- struct{}{} }() startTime := time.Now() res = v3.mustDoV3RequestWithPos(t, aliceToken, res.Pos, req) @@ -286,6 +288,8 @@ func TestConnectionTimeoutNotReset(t *testing.T) { } m.MatchResponse(t, res, m.MatchList("a", m.MatchV3Count(2)), m.MatchNoV3Ops()) + // Wait for all the responses before closing the v2 server. + <-done } // Test that the txn_id is echoed back