New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing types in interface ILazyLoadOptions #480

Closed

that-bman opened this issue Aug 31, 2020 · 3 comments

Labels

that-bman commented Aug 31, 2020

Describe the bug
The typings need updating with the missing types:

data_bg_hidpi
data_bg_multi
data_bg_multi_hidpi
data_poster
class_applied
unobserve_completed
unobserve_entered
cancel_on_exit
callback_applied
callback_cancel

https://github.com/verlok/vanilla-lazyload/blob/master/typings/lazyload.d.ts

LazyLoad version

Version 17.1.2

that-bman added the TYPE: Bug label

ar53n mentioned this issue

fix types for options #482

Merged

Contributor

ar53n commented Sep 3, 2020 •

edited

Loading

@that-bman check pls typings in PR

erichstark commented Sep 29, 2020

Thats great! I was considering to work on it 👍

Owner

verlok commented Oct 17, 2020

Merged #482. Releasing a new version. Thank you all!

verlok closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment