Not Found if repository url doesn't end with ".git"

[spebern]

If I execute magit-status in certain repos I get the following error:
Not Found: "GET", "/repos/////issues", nil, nil, ((message . "Not Found") (documentation_url "https://developer.github.com/v3"))

The repository url returned by (magit-get "remote" (magithub-source--remote) "url") is [email protected]:spebern/Bailador

As soon as a repositry url does not end with ".git" it won't match the regex parsing that url, because
".git" is not optional.

[zakame]

Just ran into this my now, mainly on Go repos fetched via go get.

[vermiculus]

@zakame, do you have steps to reproduce? :-)

[zakame]

@vermiculus sure, for me it was getting docker-machine-kvm via go get:

[zakame:~] 2 % GOPATH=~/altgo go get -u -v -x github.com/dhiltgen/docker-machine-kvm 
github.com/dhiltgen/docker-machine-kvm (download)
created GOPATH=/home/zakame/altgo; see 'go help gopath'
cd .
git clone https://github.com/dhiltgen/docker-machine-kvm /home/zakame/altgo/src/github.com/dhiltgen/docker-machine-kvm
cd /home/zakame/altgo/src/github.com/dhiltgen/docker-machine-kvm
git submodule update --init --recursive
cd /home/zakame/altgo/src/github.com/dhiltgen/docker-machine-kvm
git show-ref
cd /home/zakame/altgo/src/github.com/dhiltgen/docker-machine-kvm
git submodule update --init --recursive
github.com/docker/machine (download)
cd .
git clone https://github.com/docker/machine /home/zakame/altgo/src/github.com/docker/machine
cd /home/zakame/altgo/src/github.com/docker/machine
git submodule update --init --recursive
cd /home/zakame/altgo/src/github.com/docker/machine
git show-ref
cd /home/zakame/altgo/src/github.com/docker/machine
git submodule update --init --recursive
cd /home/zakame/altgo/src/github.com/docker/machine
git config remote.origin.url
cd /home/zakame/altgo/src/github.com/docker/machine
git config remote.origin.url
cd /home/zakame/altgo/src/github.com/docker/machine
git config remote.origin.url
cd /home/zakame/altgo/src/github.com/docker/machine
git config remote.origin.url
cd /home/zakame/altgo/src/github.com/docker/machine
git config remote.origin.url
cd /home/zakame/altgo/src/github.com/docker/machine
git config remote.origin.url
cd /home/zakame/altgo/src/github.com/docker/machine
git config remote.origin.url
github.com/libvirt/libvirt-go (download)
cd .
git clone https://github.com/libvirt/libvirt-go /home/zakame/altgo/src/github.com/libvirt/libvirt-go
cd /home/zakame/altgo/src/github.com/libvirt/libvirt-go
git submodule update --init --recursive
cd /home/zakame/altgo/src/github.com/libvirt/libvirt-go
git show-ref
cd /home/zakame/altgo/src/github.com/libvirt/libvirt-go
git submodule update --init --recursive
WORK=/tmp/go-build974707010
...
cp $WORK/github.com/dhiltgen/docker-machine-kvm.a /home/zakame/altgo/pkg/linux_amd64/github.com/dhiltgen/docker-machine-kvm.a
θ71° [zakame:~] 10m12s % 

Note that the git clones above does use the GitHub URL of the repo directly, not the proper .git URL, so I suppose this might be a Go issue as well. Visiting any repos ~/altgo/src/github.com/ with magithub results in

Not Found: "GET", "/repos/////issues", nil, nil, ((message . "Not Found") (documentation_url . "https://developer.github.com/v3"))

which I think might be caused by magithub--url->repo failing to match what remote it can find in .git/config.

[vermiculus]

Related to #105

[vermiculus]

Closing as a duplicate of #105. Thanks for the information though – it was invaluable!

[zakame]

Thanks @vermiculus @spebern !