Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated Last-modified header value uses the wrong timezone #25

Open
avdv opened this issue Dec 23, 2014 · 0 comments
Open

generated Last-modified header value uses the wrong timezone #25

avdv opened this issue Dec 23, 2014 · 0 comments

Comments

@avdv
Copy link

avdv commented Dec 23, 2014

The StaticFileHandler generates Last-Modified headers with the timezone set to the current system's timezone.

It should use GMT as defined by http://tools.ietf.org/html/rfc2616#section-3.3

HTTP/1.1 200 OK
last-modified: Thu, 18 Dec 2014 11:21:17 CET
...

REDbot complains again:

  • The last-modified header's value isn't a valid date.

    HTTP dates have very specific syntax, and sending an invalid date can
    cause a number of problems, especially around caching. Common problems
    include sending "1 May" instead of "01 May" (the month is a fixed-
    width field), and sending a date in a timezone other than GMT. See the
    HTTP specification for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant