Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json Module should output type error on iterables that are not encodable #187

Open
moehajj opened this issue Oct 11, 2021 · 0 comments
Open

Json Module should output type error on iterables that are not encodable #187

moehajj opened this issue Oct 11, 2021 · 0 comments
Labels
enhancement Enhance functionality in Starlarky python-compat New feature or request triaged

Comments

@moehajj
Copy link
Contributor

moehajj commented Oct 11, 2021 •
edited
Loading

Problem or feature statement

Currently the Json Module allows for parsing all iterables, including user-defined iterables, while in python it returns Object of type XXXX is not JSON serializable for user-defined iterables. This is non-conformant to python.

Advised solution

Return Object of type XXXX is not JSON serializable when trying to parse user-defined iterables in the Json Module.
@mahmoudimus mahmoudimus added python-compat New feature or request enhancement Enhance functionality in Starlarky labels Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhance functionality in Starlarky python-compat New feature or request triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mahmoudimus @aslepakurov @moehajj