Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more configurable options for pod template #35

Closed
wey-gu opened this issue Jun 22, 2021 · 3 comments
Closed

add more configurable options for pod template #35

wey-gu opened this issue Jun 22, 2021 · 3 comments

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Jun 22, 2021

During the tests of MEG friends, it's found there could be a conflict between nebulaCluster pods and istio-proxy sidecar pods, in order to disable the sidecar, below annotation fields are needed.

IMG_0546

While for now, there is no such configuration interface to do so.

Is it feasible to add configurable options on this kind of k/v pairs via values.yaml ?

@veezhang
Copy link
Contributor

@wey-gu Oh, Good idea!

@veezhang
Copy link
Contributor

veezhang commented Jun 24, 2021

@wey-gu It's fix in #36

After merged, please configure 'nebula.podAnnotations.sidecar\.istio\.io/inject with false.

Notes:

  • update the operator images
  • update helm repo
    # If you have already added it, please skip.
    $ helm repo add nebula-operator https://vesoft-inc.github.io/nebula-operator/charts
    $ helm repo update
  • re-install operator with --set 'image.nebulaOperator.imagePullPolicy'=Always
    # for example
    # image.nebulaOperator.imagePullPolicy'=Always is used for update the images
    $ helm uninstall nebula-operator --namespace nebula-operator-system
    $ kubectl delete crd nebulaclusters.apps.nebula-graph.io
    $ helm install nebula-operator ./charts/nebula-operator \          
        --namespace nebula-operator-system --create-namespace \
        --set 'image.nebulaOperator.imagePullPolicy'=Always

For example:

$ export NEBULA_CLUSTER_NAME=nebula           # the name for nebula cluster
$ export NEBULA_CLUSTER_NAMESPACE=nebula      # the namespace you want to install the nebula cluster
$ export STORAGE_CLASS_NAME=standard          # the storage class for the nebula cluster

$ helm install "${NEBULA_CLUSTER_NAME}" nebula-operator/nebula-cluster \
    --namespace="${NEBULA_CLUSTER_NAMESPACE}" --create-namespace\
    --set nameOverride=${NEBULA_CLUSTER_NAME} \
    --set nebula.storageClassName="${STORAGE_CLASS_NAME}" \
    --set-string 'nebula.podAnnotations.sidecar\.istio\.io/inject='false

$ kubectl get pod -n ${NEBULA_CLUSTER_NAMESPACE} -l app.kubernetes.io/cluster=${NEBULA_CLUSTER_NAME} \
    -o custom-columns='NAME:.metadata.name,Inject:.metadata.annotations.sidecar\.istio\.io/inject'
NAME                Inject
nebula-graphd-0     false
nebula-graphd-1     false
nebula-metad-0      false
nebula-metad-1      false
nebula-metad-2      false
nebula-storaged-0   false
nebula-storaged-2   false

@wey-gu
Copy link
Contributor Author

wey-gu commented Jun 24, 2021

@veezhang wow, thanks!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants