Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the expected behavior when Go over multiple edgeTypes, but filter is applied to one edgeType #2166

Closed
critical27 opened this issue Jun 8, 2020 · 3 comments
Assignees
Labels
doc affected PR: improvements or additions to documentation

Comments

@critical27
Copy link
Contributor

critical27 commented Jun 8, 2020

create edge e1(p1 int)
insert edge e1(p1) values 1 -> 1:(1)
insert edge e1(p1) values 1 -> 2:(2)
insert edge e1(p1) values 1 -> 3:(3)
insert edge e1(p1) values 1 -> 4:(4)
insert edge e1(p1) values 1 -> 5:(5)

create edge e2(p1 int)
insert edge e2(p1) values 1 -> 1:(1)

go from 1 over e1, e2 where e1.p1 > 3

What is the expected behavior when Go over multiple edgeTypes, but filter is applied to one edgeType?

image

go from 1 over e1, e2 where e1.p1 > 3 || e2.p1 > 0

Result of this query make more sense.

image

@critical27
Copy link
Contributor Author

critical27 commented Jun 8, 2020

IMO, we should return edges of e1 which can pass filter and all edges of e2. Also I think the filter in our interface, should only applied to one edge type. However, we could support filter in each edgeTypes. For example, sth like:

go from 1 over e1 (where e1.p1 > 3), e2 (where e2.p1 > 0)

@amber-moe amber-moe added the doc affected PR: improvements or additions to documentation label Jun 8, 2020
@amber-moe
Copy link
Contributor

Good point. Will update the doc when this issue is addressed.

@CPWstatic
Copy link
Contributor

As we discussed offline, the existing behavior is in line with expectations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

6 participants