Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It should show normal version info in nightly pacakge,eg: 3.0.0-nightly-aeds5d2 #3956

Closed
xigongdaEricyang opened this issue Mar 1, 2022 · 2 comments · Fixed by #4006
Closed

It should show normal version info in nightly pacakge,eg: 3.0.0-nightly-aeds5d2 #3956

xigongdaEricyang opened this issue Mar 1, 2022 · 2 comments · Fixed by #4006
Assignees
@CPWstatic
Labels
type/feature req Type: feature request

Comments

@xigongdaEricyang
Copy link

Is your feature request related to a problem? Please describe.

We find when use nightly nebula, the version shows empty string or commit id, we want to add version info.
For example: 3.0.0-nightly-aeds5d2 , the syntax is "[semver version]-[nightly]-[commitid]"
Describe the solution you'd like

Describe alternatives you've considered

Additional context
@xigongdaEricyang xigongdaEricyang added the type/feature req Type: feature request label Mar 1, 2022
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Mar 1, 2022
@Sophie-Xie Sophie-Xie moved this from Todo to Backlog in Nebula Graph v3.1.0 Mar 4, 2022
@jamieliu1023 jamieliu1023 mentioned this issue Mar 5, 2022
Closed
@Sophie-Xie Sophie-Xie moved this from Backlog to Reviewing in Nebula Graph v3.1.0 Mar 11, 2022
@CPWstatic
Copy link
Contributor

Would it be helpful if the version name is nightly-aeds5d2?

@CPWstatic CPWstatic mentioned this issue Mar 14, 2022
Merged
11 tasks
Repository owner moved this from Reviewing to Done in Nebula Graph v3.1.0 Mar 15, 2022
@jamieliu1023 jamieliu1023 mentioned this issue Mar 19, 2022
Closed
@Sophie-Xie
Copy link
Contributor

revert this issue by #4043

@Sophie-Xie Sophie-Xie removed this from the v3.1.0 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CPWstatic CPWstatic

Labels
type/feature req Type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add version for nightly. CPWstatic/nebula
3 participants
@xigongdaEricyang @CPWstatic @Sophie-Xie