fix: remove deps from optional

videojs · Jun 11, 2018 · 21a93b8 · 21a93b8
1 parent 6fcb9e6
commit 21a93b8
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 69 deletions.
diff --git a/generators/app/package-json.js b/generators/app/package-json.js
@@ -8,14 +8,14 @@ pkg.optionalDependencies = pkg.optionalDependencies || {};
 pkg.devDependencies = pkg.devDependencies || {};
 
 const getGeneratorVersion = (pkgName) =>
-  pkg.optionalDependencies[pkgName] || pkg.devDependencies[pkgName];
+  pkg.optionalDependencies[pkgName] || pkg.devDependencies[pkgName] || pkg.dependencies[pkgName];
 
 const getGeneratorVersions = (pkgList) => pkgList.reduce((acc, pkgName) => {
   const version = getGeneratorVersion(pkgName);
 
   if (!version) {
     throw new Error(
-      `Error ${pkgName} is not in optional/devdependencies for generator-videojs-plugin`
+      `Error ${pkgName} is not in dependencies for generator-videojs-plugin`
     );
   }
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -78,15 +78,13 @@
     "postcss-import": "^11.1.0",
     "postcss-preset-env": "^5.1.0",
     "qunit": "^2.5.1",
-    "rimraf": "^2.6.2",
     "rollup": "^0.60.1",
     "rollup-plugin-babel": "^3.0.4",
     "rollup-plugin-commonjs": "^9.1.3",
     "rollup-plugin-json": "^3.0.0",
     "rollup-plugin-multi-entry": "^2.0.2",
     "rollup-plugin-node-resolve": "^3.0.0",
     "rollup-plugin-uglify": "^4.0.0",
-    "semver": "^5.4.1",
     "sinon": "^5.1.0",
     "uglify-es": "^3.3.9",
     "video.js": "6.10.2 || ^7.0.3",