Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove Sass support option. #152

Merged
merged 1 commit into from
Jun 5, 2018
Merged

feat: Remove Sass support option. #152

merged 1 commit into from
Jun 5, 2018

Conversation

misteroneill
Copy link
Member

BREAKING CHANGE: Generated projects no longer support Sass out of the box.

@misteroneill misteroneill added this to the v6.0.0 milestone Feb 3, 2018
@misteroneill misteroneill changed the base branch from master to next February 3, 2018 16:53
Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with this PR so long as we make sure that it won't remove sass when people upgrade, and if we offer an alternative before v6 goes out.

@misteroneill
Copy link
Member Author

Yeah, I think we should offer something - probably PostCSS or, maybe, LESS.

@gkatsev
Copy link
Member

gkatsev commented Feb 8, 2018

postcss, or just nothing and let users choose what they want.
I do agree that it should make sure not to remove sass when upgrading and it is currently being used. Probably should ask "are you currently using sass? Do you want to continue using sass?"

@gkatsev
Copy link
Member

gkatsev commented Feb 8, 2018

we can always add postcss later if we want to go that route.

@misteroneill
Copy link
Member Author

misteroneill commented Feb 8, 2018

I like that idea. We can add PostCSS as a minor at some point. Part of the idea here is that the generator's output should be light-weight.

Perhaps, by default, we could allow for plain CSS support where it simply takes src/foo.css and copies it to dist/foo.css. Maybe with minification.

The generator is generally non-destructive, so I don't think it will remove Sass if it's in use. I'll verify, though.

Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More code removal!

@brandonocasey brandonocasey changed the base branch from next to master June 5, 2018 16:38
@brandonocasey brandonocasey reopened this Jun 5, 2018
BREAKING CHANGE: Generated projects no longer support Sass out of the box.
@brandonocasey brandonocasey merged commit eab6398 into master Jun 5, 2018
@brandonocasey brandonocasey deleted the remove-sass branch June 5, 2018 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants