-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove Sass support option. #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK with this PR so long as we make sure that it won't remove sass when people upgrade, and if we offer an alternative before v6 goes out.
Yeah, I think we should offer something - probably PostCSS or, maybe, LESS. |
postcss, or just nothing and let users choose what they want. |
we can always add postcss later if we want to go that route. |
I like that idea. We can add PostCSS as a minor at some point. Part of the idea here is that the generator's output should be light-weight. Perhaps, by default, we could allow for plain CSS support where it simply takes The generator is generally non-destructive, so I don't think it will remove Sass if it's in use. I'll verify, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More code removal!
9ea97e4
to
7e3e31b
Compare
BREAKING CHANGE: Generated projects no longer support Sass out of the box.
7e3e31b
to
d403ba9
Compare
BREAKING CHANGE: Generated projects no longer support Sass out of the box.