feat: add teamcity & browserstack support #185
Conversation
| const StaticMiddlewareFactory = function(config) { | ||
| console.log(`**** Dev server started at http://${config.listenAddress}:${config.port}/ *****`); | ||
| console.log(`**** Karma static file server enabled in project root *****`); |
There was a problem hiding this comment.
small change here, config.port would be wrong if the port is in-use and has to be incremented.
| const serve = serveStatic( | ||
| config.basePath, | ||
| {index: ['index.html', 'index.htm']} | ||
| ); |
There was a problem hiding this comment.
We should server the basePath, rather than trying to determine our own.
brandonocasey
force-pushed
the
feat/teamcity-browserstack
branch
from
eae31ab to
11802cf
Compare
| const StaticMiddlewareFactory = function(config) { | ||
| console.log(`**** Dev server started at http://${config.listenAddress}:${config.port}/ *****`); |
There was a problem hiding this comment.
is this info being printed elsewhere?
There was a problem hiding this comment.
The karma server prints it when it starts up. Oftentimes the address we were printing here is the address we were passed. This means that when port 9999 is in use and get incremented by karma to 10000. we still print 9999.
brandonocasey
force-pushed
the
feat/teamcity-browserstack
branch
from
307ac4f to
2ef0dea
Compare
generators/app/index.js
Outdated
| @@ -305,16 +305,14 @@ module.exports = class extends Generator { | |||
|
|
|||
| const file = constants.LICENSE_FILES[this.config.get('license')]; | |||
|
|
|||
| if (!file) { | |||
| return; | |||
| if (file) { | |||
There was a problem hiding this comment.
Fixes a bug where un-licensed would cause the package.json not to be copied.
|
|
||
| /* General Globals */ | ||
| const moduleName = '<%= moduleName %>'; | ||
| const pluginName = '<%= pluginName %>'; |
There was a problem hiding this comment.
Mostly I added all the main variables at the top of the file, so that users won't have to dig into the actual builds unless they really need to.
| usePhantomJS: false | ||
| }; | ||
| /* browsers to run on teamcity */ | ||
| const teamcityLaunchers = { |
There was a problem hiding this comment.
this seems a confusing name given that these browsers are set up to work with browserstack.
There was a problem hiding this comment.
yeah it is maybe we should split it into teamcityLaunchers, and browserstackLaunchers
There was a problem hiding this comment.
yeah, I would just call these browserstackLaunchers and just use it in TC usecase below or something.
|
Also, would've been nice if the rollup changes, karma changes, and the fix for package.json were all in separate PRs. |
|
I will split up the prs |
brandonocasey
force-pushed
the
feat/teamcity-browserstack
branch
from
24b6939 to
dc8cbd7
Compare
No description provided.