Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: simplify karma config #211

Merged
merged 1 commit into from
Aug 17, 2018
Merged

feat: simplify karma config #211

merged 1 commit into from
Aug 17, 2018

Conversation

brandonocasey
Copy link
Contributor

@brandonocasey brandonocasey commented Aug 16, 2018 •
edited
Loading

Drastically simplify the generator with a package.
See videojs/videojs-generate-karma-config#1

@brandonocasey brandonocasey mentioned this pull request Aug 16, 2018
Merged
misteroneill
misteroneill approved these changes Aug 17, 2018
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like test needs a quick update, but otherwise looks good

@brandonocasey brandonocasey force-pushed the feat/simplify-karma-config branch from e0ebc86 to 6684d37 Compare August 17, 2018 19:53
@brandonocasey brandonocasey force-pushed the feat/simplify-karma-config branch from 6684d37 to 63f8157 Compare August 17, 2018 19:54
@brandonocasey brandonocasey merged commit add0696 into master Aug 17, 2018
@brandonocasey brandonocasey deleted the feat/simplify-karma-config branch August 17, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonocasey @misteroneill