feat: Use videojs-generator-verify to verify new packages #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
feat/vjsverify
branch
4 times, most recently
from
29b06b8 to
9d9f145
Compare
brandonocasey
force-pushed
the
master
branch
4 times, most recently
from
bb5be65 to
2bdf4c8
Compare
brandonocasey
force-pushed
the
feat/vjsverify
branch
from
9d9f145 to
733aa99
Compare
brandonocasey
commented
Sep 12, 2018
generators/app/package-json.js
Outdated
| @@ -142,7 +141,7 @@ const packageJSON = (current, context) => { | |||
| 'clean': 'shx rm -rf ./dist ./test/dist', | |||
| 'postclean': 'shx mkdir -p ./dist ./test/dist', | |||
| 'lint': 'vjsstandard', | |||
| 'prepublish': 'not-in-install && npm run build && pkg-ok || in-install', | |||
| 'prepublishOnly': 'npm run build && vjsverify', | |||
There was a problem hiding this comment.
not-in-install was not working correctly for me with npm@6, this may be something we have to update our projects with right away.
There was a problem hiding this comment.
Can not-in-install be fixed for npm@6 rather than opening a bunch more PRs?
There was a problem hiding this comment.
good question let me check
brandonocasey
commented
Sep 12, 2018
| @@ -3,8 +3,12 @@ | |||
| const helpers = require('yeoman-test'); | |||
There was a problem hiding this comment.
I re-worked this file a lot, we now make sure that the version, ci, install and prepublishOnly scripts will work by using the various commands. In the future we should probably add audit here as well.
brandonocasey
force-pushed
the
feat/vjsverify
branch
3 times, most recently
from
3208a75 to
adf411d
Compare
brandonocasey
force-pushed
the
feat/vjsverify
branch
7 times, most recently
from
91ce039 to
95c17a2
Compare
brandonocasey
force-pushed
the
feat/vjsverify
branch
from
95c17a2 to
a5cd321
Compare
misteroneill
approved these changes
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on videojs/videojs-generator-verify#1
Closes #230