feat: generate package-lock for faster install #233
Conversation
|
Interesting idea. With this, we can even run |
|
Yeah we could, we would just have to version check npm, let me see if yeoman can do it |
brandonocasey
force-pushed
the
feat/pkg-lock-generation
branch
from
e563c6a to
bdc0e9e
Compare
brandonocasey
force-pushed
the
feat/pkg-lock-generation
branch
from
bdc0e9e to
ae9f4d7
Compare
|
I think you could simply skip the Really cool idea! 👍 |
|
So first we check if we have npm <= 5 and if so, we won't have the |
| @@ -26,7 +26,8 @@ | |||
| "test": "npm-run-all test:*", | |||
| "test:unit": "mocha test/*.test.js", | |||
| "test:integration": "node scripts/run-integration-tests.js", | |||
| "preversion": "npm run test", | |||
| "preversion": "npm-run-all generate-pkg-lock test", | |||
| "generate-pkg-lock": "node scripts/generate-pkg-lock.t js && git add generators/app/templates/_package-lock.json", | |||
There was a problem hiding this comment.
generate package lock and add it every version, I think this makes sense to me.
| }) | ||
| .withOptions(libs.options()) | ||
| .withOptions(Object.assign(libs.options(), {skipInstall: false})) |
There was a problem hiding this comment.
I removed the install steps below, instead we do the builtin yeoman install
Generate a package lock for plugin to save ~70s on initial install, even when deps have changed by selecting other options.