fix: The --hurry option #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
fix/hurry
branch
from
23dd643 to
e407277
Compare
brandonocasey
commented
Sep 13, 2018
| docs: false, | ||
| css: false, | ||
| docs: true, | ||
| css: true, |
There was a problem hiding this comment.
We can drop these changes here if we want, but I think that we want to offer the full toolset for --hurry.
brandonocasey
commented
Sep 13, 2018
| @@ -242,6 +246,7 @@ module.exports = class extends Generator { | |||
| */ | |||
| prompting() { | |||
| if (this.options.skipPrompt) { | |||
| _.assign(this._preconfigs, this._getPromptDefaults()); | |||
There was a problem hiding this comment.
Previously we did not set defaults for --hurry so everything was just undefined.
brandonocasey
commented
Sep 13, 2018
| @@ -77,6 +77,10 @@ module.exports = class extends Generator { | |||
| // purposes of the prompt (otherwise it will be rejected by validation). | |||
| defaults.name = naming.getBasicName(defaults.name); | |||
|
|
|||
| // we need to default the description to an empty string for | |||
| // --hurry | |||
| defaults.description = ''; | |||
There was a problem hiding this comment.
We did not have a default for description and we need one if we don't have a prompt.
misteroneill
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #178