feat: Update to videojs-generate-rollup-config ~5.0.0, use env options, and @babel/runtime
#289
Conversation
| @@ -124,18 +124,16 @@ const packageJSON = (current, context) => { | |||
| 'ie 11' | |||
| ], | |||
| 'scripts': _.assign({}, current.scripts, { | |||
| 'prebuild': 'npm run clean', | |||
There was a problem hiding this comment.
Previously we used to do this prebuild, but since we have multiple different types of "build" now, it doesn't make sense.
| 'build:js': 'rollup -c scripts/rollup.config.js', | ||
| 'clean': 'shx rm -rf ./dist ./test/dist', | ||
| 'postclean': 'shx mkdir -p ./dist ./test/dist', | ||
| 'clean': 'shx rm -rf ./dist ./test/dist && shx mkdir -p ./dist ./test/dist', |
There was a problem hiding this comment.
May as well do it in one command
There was a problem hiding this comment.
Although, I don't think&& will work on Windows, will it?
generators/app/package-json.js
Outdated
| 'prebuild': 'npm run clean', | ||
| 'build': 'npm-run-all -p build:*', | ||
| 'build-test': "npm-run-all -s clean -p 'build:!(js)' 'build:js -- --environment TEST_BUNDLE_ONLY'", | ||
| 'build-prod': "npm-run-all -s clean -p 'build:!(js)' 'build:js -- --environment NO_TEST_BUNDLE'", |
There was a problem hiding this comment.
build:!(js) is run all build commands except for js, then we run it separately with an environment variable.
There was a problem hiding this comment.
I didn't know npm-run-all supported segation like that, nice.
| 'lint': 'vjsstandard', | ||
| 'prepublishOnly': 'npm-run-all build test:verify', | ||
| 'prepublishOnly': 'npm-run-all build-prod && vjsverify --verbose', |
There was a problem hiding this comment.
verify can no longer be run on test so it only makes sense in pre-publish.
brandonocasey
force-pushed
the
feat/new-rollup-env-options
branch
from
4bef566 to
be47d3b
Compare
brandonocasey
force-pushed
the
feat/new-rollup-env-options
branch
from
be47d3b to
54dfed0
Compare
brandonocasey
force-pushed
the
feat/new-rollup-env-options
branch
from
f102dd7 to
70b6996
Compare
brandonocasey
force-pushed
the
feat/new-rollup-env-options
branch
from
48f6203 to
bb48b6c
Compare
brandonocasey
changed the title
@babel/runtime
| }, | ||
| "devDependencies": { | ||
| "@videojs/generator-helpers": "~1.1.1", | ||
| "@videojs/generator-helpers": "~1.2.0", |
There was a problem hiding this comment.
This provides cross-env
| 'build:js': 'rollup -c scripts/rollup.config.js', | ||
| 'clean': 'shx rm -rf ./dist ./test/dist', | ||
| 'postclean': 'shx mkdir -p ./dist ./test/dist', | ||
| 'clean': 'shx rm -rf ./dist ./test/dist && shx mkdir -p ./dist ./test/dist', |
There was a problem hiding this comment.
Although, I don't think&& will work on Windows, will it?
Use new environment variable options from
videojs-generate-rollup-config@~4.0.0and@babel/runtimefromvideojs-generate-rollup-config@~5.0.0.See: https://github.com/videojs/videojs-generate-rollup-config/blob/master/CHANGELOG.md
Depends upon: videojs/generator-helpers#2