feat: support libraries, via @videojs/babel-config #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Oct 8, 2020
| spawnSync('npm', ['i', '--package-lock-only'], {stdio: 'inherit', cwd: this.destinationRoot()}); | ||
| spawnSync('npm', ['ci'], {stdio: 'inherit', cwd: this.destinationRoot()}); | ||
|
|
||
| spawnSync('npm', ['i', '--prefer-offline', '--no-audit', '--progress=false'], {stdio: 'inherit', cwd: this.destinationRoot()}); |
There was a problem hiding this comment.
the speed of npm i with all of these options is ~20s faster then npm ci
brandonocasey
force-pushed
the
feat/library
branch
from
30039f6 to
15eeac5
Compare
brandonocasey
force-pushed
the
feat/library
branch
from
15eeac5 to
54031f0
Compare
misteroneill
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support "libraries" that compile their module output to
./esand./cjsfor consumption by other node packages and our bundlers.Requires:
fix: minifier plugin, babel-config update videojs-generate-rollup-config#36feat: Refactor to support a test to require and es-checking library files videojs-generator-verify#7