feat(BREAKING): switch to node 14 and only test on safari 12/14, chrome, and firefox #307
Conversation
brandonocasey
force-pushed
the
feat/node-14
branch
from
22d31c4 to
586a0d1
Compare
| @@ -0,0 +1,77 @@ | |||
| name: ci | |||
There was a problem hiding this comment.
do we want this here? Since it's sort of specific to Videojs projects only and not everyone may want this. Plus, it'll be yet another place we have to maintain this file.
There was a problem hiding this comment.
Maybe, but we already included the travis config previously and didn't add it to the project if it was closed source. Should we fetch it on install?
There was a problem hiding this comment.
downloading it from the .github repo sounds like a good idea. That way we don't have to maintain the script in yet another location.
There was a problem hiding this comment.
ok I have it downloading now.
plugin/package.json
Outdated
| "global": "^4.4.0", | ||
| "video.js": "^6 || ^7" | ||
| "video.js": "^7.12.1" |
There was a problem hiding this comment.
I think this should stay the same
There was a problem hiding this comment.
I'm not sure that video.js 6 with support node 14
There was a problem hiding this comment.
I don't see that as an issue. The node support in Video.js is mostly in running the build itself. You definitely should be able to require vjs 6 in node 14 (and have it be a no-op, as it is now).
Ideally, this would stay the same until someone updates their plugin to not support IE11 and depend on Video.js 8.
brandonocasey
changed the title
node 8/10 are dead, 12 is very old, and 16 is very new. Let's make the jump to 14.