From 980776c8327c406ccede6061af164afc7589a3a7 Mon Sep 17 00:00:00 2001 From: brandonocasey Date: Mon, 22 Apr 2019 12:19:36 -0400 Subject: [PATCH 1/3] docs: update packages that can be removed --- README.md | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/README.md b/README.md index 55f1238d..222be4b4 100644 --- a/README.md +++ b/README.md @@ -30,6 +30,7 @@ To learn more about Video.js plugins and this generator's conventions and opinio - [Hurry](#hurry) - [Updating an Existing Project](#updating-an-existing-project) - [Recommendations](#recommendations) + - [Migrating to the Latest Version](#migrating-to-the-latest-version) - [License](#license) @@ -139,6 +140,17 @@ semver serve-static sinon uglify-es +conventional-changelog-cli +conventional-changelog-videojs +doctoc +husky +lint-staged +not-prerelease +npm-merge-driver-install +npm-run-all +shx +pkg-ok +in-publish ``` All these dependencies should be removable because, in general, build tools are now using the new `videojs-generate-*` libraries. This should make it easier to manage dependencies by offloading much of that work to the Video.js organization. The behavior of these new tools is customizable by editing the files in `scripts/`. From b247cbe8754d55067fb31d10c7627b9f3a4f5523 Mon Sep 17 00:00:00 2001 From: brandonocasey Date: Mon, 22 Apr 2019 12:42:17 -0400 Subject: [PATCH 2/3] cr --- README.md | 84 ++++++++++++++++++++++++++++++++++++++++--------------- 1 file changed, 61 insertions(+), 23 deletions(-) diff --git a/README.md b/README.md index 222be4b4..712d6f8f 100644 --- a/README.md +++ b/README.md @@ -31,6 +31,13 @@ To learn more about Video.js plugins and this generator's conventions and opinio - [Updating an Existing Project](#updating-an-existing-project) - [Recommendations](#recommendations) - [Migrating to the Latest Version](#migrating-to-the-latest-version) + - [Where do dependencies come from?](#where-do-dependencies-come-from) + - [`videojs-generate-rollup-config`](#videojs-generate-rollup-config) + - [`videojs-genreate-karma-config`](#videojs-genreate-karma-config) + - [`videojs-generate-postcss-config`](#videojs-generate-postcss-config) + - [`videojs-generator-verify`](#videojs-generator-verify) + - [`@videojs/generator-helpers`](#videojsgenerator-helpers) + - [No longer needed](#no-longer-needed) - [License](#license) @@ -112,34 +119,68 @@ If you have made no customizations, the simplest process may be to remove some o - `test/karma.conf.js` - `test/index.html` -For a more conservative approach, you should be able to remove any of the following `devDependencies` from your generated project: +For a more conservative approach, you should be able to remove any dependencies not listed in [`plugin/package.json`](plugin/package.json) unless it is specifically needed by your project. +### Where do dependencies come from? + +#### `videojs-generate-rollup-config` ``` babel-core babel-plugin-external-helpers babel-plugin-transform-object-assign babel-preset-env +@babel/preset-env +@babel/plugin-transform-object-assign +@babel/core +@babel/plugin-external-helpers +rollup-plugin-babel +rollup-plugin-commonjs +rollup-plugin-json +rollup-plugin-multi-entry +rollup-plugin-node-resolve +rollup-plugin-uglify +rollup-plugin-terser +uglify-es +``` + +#### `videojs-genreate-karma-config` +``` karma-browserstack-launcher karma-chrome-launcher +karma-coverage karma-detect-browsers karma-firefox-launcher karma-ie-launcher karma-qunit karma-safari-launcher +karma-safaritechpreview-launcher +karma-safari-applescript-launcher karma-teamcity-reporter -mkdirp +karma-static-server qunit -rimraf -rollup-plugin-babel -rollup-plugin-commonjs -rollup-plugin-json -rollup-plugin-multi-entry -rollup-plugin-node-resolve -rollup-plugin-uglify -semver -serve-static -sinon -uglify-es +``` + +#### `videojs-generate-postcss-config` +``` +autoprefixer +postcss-banner +postcss-calc +postcss-csso +postcss-custom-properties +postcss-import +postcss-nesting +postcss-progress +``` + +#### `videojs-generator-verify` +``` +es-check +pkg-ok +pkg-can-install +``` + +#### `@videojs/generator-helpers` +``` conventional-changelog-cli conventional-changelog-videojs doctoc @@ -149,19 +190,16 @@ not-prerelease npm-merge-driver-install npm-run-all shx -pkg-ok -in-publish ``` -All these dependencies should be removable because, in general, build tools are now using the new `videojs-generate-*` libraries. This should make it easier to manage dependencies by offloading much of that work to the Video.js organization. The behavior of these new tools is customizable by editing the files in `scripts/`. - -Regardless, you'll almost certainly want allow the generator to fully overwrite all files as described in the previous section - except those that are likely to have been edited by you: - -- `src/*` -- `test/*.test.js` -- `README.md` +#### No longer needed -Finally, be sure to run, at minimum, `npm test` afterward to make sure your stuff still works! +No longer needed for other reasons +* `serve-static`: replaced by `karma-static-server` +* `in-publish`: replaced by using `prepublishOnly` via a new version of npm +* `mkdirp`: replaced by using `shx` +* `rimraf`: replaced by using `shx` +* `semver`: replaced by `@videojs/generator-helpers` ## License From 926944c167c1638d73b3a0c13a37de25361c3e03 Mon Sep 17 00:00:00 2001 From: brandonocasey Date: Mon, 22 Apr 2019 13:14:29 -0400 Subject: [PATCH 3/3] typo --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 712d6f8f..558a1c17 100644 --- a/README.md +++ b/README.md @@ -33,7 +33,7 @@ To learn more about Video.js plugins and this generator's conventions and opinio - [Migrating to the Latest Version](#migrating-to-the-latest-version) - [Where do dependencies come from?](#where-do-dependencies-come-from) - [`videojs-generate-rollup-config`](#videojs-generate-rollup-config) - - [`videojs-genreate-karma-config`](#videojs-genreate-karma-config) + - [`videojs-generate-karma-config`](#videojs-generate-karma-config) - [`videojs-generate-postcss-config`](#videojs-generate-postcss-config) - [`videojs-generator-verify`](#videojs-generator-verify) - [`@videojs/generator-helpers`](#videojsgenerator-helpers) @@ -143,7 +143,7 @@ rollup-plugin-terser uglify-es ``` -#### `videojs-genreate-karma-config` +#### `videojs-generate-karma-config` ``` karma-browserstack-launcher karma-chrome-launcher