fix: Throw a player error when trying to play DRM content without eme (…

…#938)

src/videojs-http-streaming.js

@@ -136,7 +136,7 @@ const emeKeySystems = (keySystemOptions, videoPlaylist, audioPlaylist) => {
     audio: audioPlaylist && audioPlaylist.attributes && audioPlaylist.attributes.CODECS
   };
 
-  if (!codecs.audio && codecs.video.split(',').length > 1) {
+  if (!codecs.audio && codecs.video && codecs.video.split(',').length > 1) {
     codecs.video.split(',').forEach(function(codec) {
       codec = codec.trim();
 
@@ -243,10 +243,6 @@ const setupEmeOptions = ({
   audioMedia,
   mainPlaylists
 }) => {
-  if (!player.eme) {
-    return;
-  }
-
   const sourceOptions = emeKeySystems(sourceKeySystems, media, audioMedia);
 
   if (!sourceOptions) {
@@ -255,6 +251,13 @@ const setupEmeOptions = ({
 
   player.currentSource().keySystems = sourceOptions;
 
+  // eme handles the rest of the setup, so if it is missing
+  // do nothing.
+  if (sourceOptions && !player.eme) {
+    videojs.log.warn('DRM encrypted source cannot be decrypted without a DRM plugin');
+    return;
+  }
+
   // works around https://bugs.chromium.org/p/chromium/issues/detail?id=895449
   // in non-IE11 browsers. In IE11 this is too early to initialize media keys
   if (videojs.browser.IE_VERSION === 11 || !player.eme.initializeMediaKeys) {

test/videojs-http-streaming.test.js

@@ -5765,9 +5765,9 @@ QUnit.module('setupEmeOptions', {
   }
 });
 
-QUnit.test('no error if no eme', function(assert) {
+QUnit.test('no error if no eme and no key systems', function(assert) {
   const player = {};
-  const sourceKeySystems = {};
+  const sourceKeySystems = null;
   const media = {};
   const audioMedia = {};
   const mainPlaylists = [];
@@ -5777,6 +5777,29 @@ QUnit.test('no error if no eme', function(assert) {
   assert.ok(true, 'no exception');
 });
 
+QUnit.test('log error if no eme and we have key systems', function(assert) {
+  const sourceKeySystems = {};
+  const media = {};
+  const audioMedia = {};
+  const mainPlaylists = [];
+  const src = {};
+  const player = {currentSource: () => src};
+
+  let logWarn;
+  const origWarn = videojs.log.warn;
+
+  videojs.log.warn = (line) => {
+    logWarn = line;
+  };
+
+  setupEmeOptions({ player, sourceKeySystems, media, audioMedia, mainPlaylists });
+
+  assert.equal(logWarn, 'DRM encrypted source cannot be decrypted without a DRM plugin', 'logs expected error');
+  assert.ok(src.hasOwnProperty('keySystems'), 'source key systems was set');
+
+  videojs.log.warn = origWarn;
+});
+
 QUnit.test('no initialize calls if no source key systems', function(assert) {
   let numInitializeCalls = 0;
   const player = { eme: { initializeMediaKeys: () => numInitializeCalls++ } };