Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: when changing renditions over a discontinuity, don't use buffere… #1023

Merged
merged 1 commit into from
Dec 7, 2020
Merged

fix: when changing renditions over a discontinuity, don't use buffere… #1023

merged 1 commit into from
Dec 7, 2020

Conversation

gesinger
Copy link
Contributor

@gesinger gesinger commented Dec 3, 2020

…d end as segment start

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@gkatsev gkatsev added this to the 2.4 milestone Dec 3, 2020
brandonocasey
brandonocasey approved these changes Dec 4, 2020
View reviewed changes
Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and code LGTM

@gkatsev gkatsev merged commit 40caa45 into videojs:main Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonocasey brandonocasey brandonocasey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.
3 participants
@gesinger @brandonocasey @gkatsev