feat: Add ability to pass encoding value for 708 captions via captionServices #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com/videojs/http-streaming into add-encoding-option-to-captionServices
gkatsev
reviewed
Sep 3, 2021
| @@ -482,6 +481,9 @@ This option defaults to `false`. | |||
| The captionServices options object has properties that map to the caption services. Each property is an object itself that includes several properties, like a label or language. | |||
|
|
|||
| For 608 captions, the service names are `CC1`, `CC2`, `CC3`, and `CC4`. For 708 captions, the service names are `SERVICEn` where `n` is a digit between `1` and `63`. | |||
|
|
|||
| For 708 caption services, you may additionally provide an `encoding` value that will be used by the transmuxer to decode the captions using an instance of [TextDecoder](https://developer.mozilla.org/en-US/docs/Web/API/TextDecoder). This is to permit and is required for legacy multi-byte encodings. Please review the `TextDecoder` documentation for accepted encoding labels. | |||
Codecov Report
@@ Coverage Diff @@
## main #1194 +/- ##
==========================================
- Coverage 86.60% 86.33% -0.27%
==========================================
Files 39 39
Lines 9652 9691 +39
Branches 2231 2243 +12
==========================================
+ Hits 8359 8367 +8
- Misses 1293 1324 +31
Continue to review full report at Codecov.
|
brandonocasey
previously approved these changes
Sep 9, 2021
gkatsev
previously approved these changes
Sep 20, 2021
alex-barstow
dismissed stale reviews from gkatsev and brandonocasey
via
d6d16f7
gkatsev
previously approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Complementary Mux.js PR: videojs/mux.js#398
The 708 implementation of mux will soon support multibyte character encodings, so this PR adds a way to pass the option to the transmuxer. using the existing
captionServicesoptions block.