fix: remove deprecation hls options, properties, and events #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #1229 +/- ##
=======================================
Coverage ? 86.25%
=======================================
Files ? 39
Lines ? 9729
Branches ? 2269
=======================================
Hits ? 8392
Misses ? 1337
Partials ? 0 Continue to review full report at Codecov.
|
35 tasks
gesinger
reviewed
Dec 15, 2021
src/videojs-http-streaming.js
Outdated
| @@ -519,42 +515,9 @@ class VhsHandler extends Component { | |||
|
|
|||
| this.logger_ = logger('VhsHandler'); | |||
|
|
|||
| // tech.player() is deprecated but setup a reference to HLS for | |||
| // backwards-compatibility | |||
| // tech.player() but we need access to the player in a few cases | |||
There was a problem hiding this comment.
I think this comment needs to be updated.
gesinger
approved these changes
Dec 15, 2021
misteroneill
pushed a commit
that referenced
this pull request
May 2, 2022
…ation guide (#1229) BREAKING CHANGE: remove deprecated options, properties, events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: remove deprecation hls options, properties, and events