Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add dateTimeObject and dateTimeString to Cues for backwards compatibility #1409

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

harisha-swaminathan
Copy link
Contributor

@harisha-swaminathan harisha-swaminathan commented Jul 24, 2023

Adds dateTimeObject and dateTimeString back to segment metadata cues for backwards compatibility

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #1409 (260324f) into main (3c5a5bc) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1409   +/-   ##
=======================================
  Coverage   85.55%   85.55%           
=======================================
  Files          41       41           
  Lines       10143    10145    +2     
  Branches     2349     2351    +2     
=======================================
+ Hits         8678     8680    +2     
  Misses       1465     1465           
Files Changed Coverage Δ
src/segment-loader.js 96.48% <100.00%> (+<0.01%) ⬆️
src/util/time.js 92.68% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants