Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: content steering bug fixes and tests #1430

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

adrums86
Copy link
Contributor

@adrums86 adrums86 commented Oct 3, 2023

Description

This PR addresses a few content steering bugs and ads some additional testing around live DASH.

Specific Changes proposed

Refactoring the content steering initialization to attach listeners separately, change some queryBeforeStart behavior and an issue with the initial ttl value.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #1430 (5bb5282) into main (dd5e2af) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1430      +/-   ##
==========================================
+ Coverage   85.98%   86.06%   +0.07%     
==========================================
  Files          42       42              
  Lines       10428    10450      +22     
  Branches     2412     2416       +4     
==========================================
+ Hits         8967     8994      +27     
+ Misses       1461     1456       -5     
Files Coverage Δ
src/content-steering-controller.js 99.44% <100.00%> (+0.01%) ⬆️
src/dash-playlist-loader.js 90.51% <100.00%> (-0.03%) ⬇️
src/playlist-controller.js 96.00% <100.00%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@wseymour15 wseymour15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@adrums86 adrums86 merged commit 532aa4d into main Nov 7, 2023
@adrums86 adrums86 deleted the live-steering-testing branch November 7, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants