Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toLowerCase keyIds from manifest and use fastQualityChange #1466

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

adrums86
Copy link
Contributor

@adrums86 adrums86 commented Dec 15, 2023

Description

Manifests with uppercase keyIds were not matching with keyIds coming from the MediaKeyStatusMap. Also occasionally we would buffer encrypted content that we may not have a key for, we need to call fastQualityChange to clear the buffer before switching playlists.

Specific Changes proposed

Add toLowerCase to the keyId from the manifest when passing the keyIdSet for playlist filtering and call fastQualityChange instead of switchMedia then fix tests.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2878b27) 86.03% compared to head (533e821) 86.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1466      +/-   ##
==========================================
- Coverage   86.03%   86.02%   -0.01%     
==========================================
  Files          42       42              
  Lines       10712    10708       -4     
  Branches     2462     2461       -1     
==========================================
- Hits         9216     9212       -4     
  Misses       1496     1496              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrums86 adrums86 marked this pull request as ready for review December 18, 2023 16:51
@adrums86 adrums86 changed the title fix: toLowerCase keyIds from manifest fix: toLowerCase keyIds from manifest and use fastQualityChange Dec 18, 2023
Copy link
Contributor

@alex-barstow alex-barstow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adrums86 adrums86 merged commit 88a5671 into main Dec 18, 2023
14 checks passed
@adrums86 adrums86 deleted the fix-toLowerCase-manifestKID branch December 18, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants