refactor: Add caption parser to the webworker to save bytes and offlo… #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
force-pushed
the
refactor/worker-caption-parser
branch
5 times, most recently
from
a49cbfb to
1acd567
Compare
brandonocasey
force-pushed
the
refactor/worker-caption-parser
branch
from
1acd567 to
6eeb707
Compare
gesinger
previously approved these changes
Jun 16, 2020
src/media-segment-request.js
Outdated
| } | ||
| finishLoading(); |
There was a problem hiding this comment.
We can save some indentation if we check for the negative case before and finishLoading() and return there.
gesinger
previously approved these changes
Jun 16, 2020
gkatsev
previously approved these changes
Jun 16, 2020
gkatsev
pushed a commit
that referenced
this pull request
Jul 6, 2020
CaptionParser can return null during parse, we used to handle this case but broke when we switched to the web worker caption parser in #863.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves us 5732 gzipped, from 77004 min gzipped in master to 71272 min gzipped in this pull request.
See videojs/mux.js#345