fix: do not try to use unsupported audio #896
Conversation
test/media-segment-request.test.js
Outdated
| this.transmuxer = this.options.segment.transmuxer; | ||
| sharedHooks.afterEach.call(this, assert); | ||
| } | ||
| }); |
test/media-segment-request.test.js
Outdated
| }); | ||
|
|
||
| /** TODO: fix this case in mux.js | ||
| QUnit.test('aac without id3 will make it to the transmuxer', function(assert) { |
There was a problem hiding this comment.
Instead of a comment, should we do a skip with the TODO for more visibility? (and same for one further down)
test/media-segment-request.test.js
Outdated
| mediaSegmentRequest(this.options); | ||
|
|
||
| assert.equal(this.requests[0].uri, 'foo.aac', 'segment-request'); | ||
| this.standardXHRResponse(this.requests[0], aacSegment()); |
There was a problem hiding this comment.
Should this be something like aacWithoutId3Segment? (and same for one further down)
|
nope didn't fix anything, but I found out the cause |
test/media-segment-request.test.js
Outdated
|
|
||
| QUnit.module('Media Segment Request - make it to transmuxer', { | ||
| beforeEach(assert) { | ||
| assert.timeout(50000); |
There was a problem hiding this comment.
Should we remove the timeout now?
src/media-segment-request.js
Outdated
| } | ||
|
|
||
| if (segment.container !== 'ts' && segment.container !== 'aac') { | ||
| trackInfoFn(segment, {hasAudio: true, hasVideo: false}); |
There was a problem hiding this comment.
Why are we reporting audio and not video if the container type is unknown?
There was a problem hiding this comment.
Originally this was because we were working with a bad audio container, but I guess it's possible that we could get here for bad video too. I pushed a commit that makes both hasAudio and hasVideo false here. Needed other changes further up the chain to support that though.
Description
Prevents unknown content from making it to the muxer and freezing the tab, such as ac3/ec3 audio in advanced bipbop ts.