feat: subtitle codecs #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonocasey
commented
Sep 28, 2020
| @@ -7,8 +7,8 @@ | |||
| <body> | |||
| <p>Open dev tools to try it out</p> | |||
| <ul> | |||
| <li><a id="test/debug.html">Run unit tests in browser.</a></li> | |||
| <li><a id="docs" href="docs/api/">Read generated docs.</a></li> | |||
| <li><a href="test/debug.html">Run unit tests in browser.</a></li> | |||
There was a problem hiding this comment.
This link didn't have a href
gkatsev
approved these changes
Sep 29, 2020
2 tasks
RomeroDiver
pushed a commit
to Arc-Soft/mpd-parser
that referenced
this pull request
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a test video that uses non-vtt captions that is making it all the way through to the vtt segment loader. We cannot filter it as we don't expose CODECS on subtitle playlists. Now we expose that so we can filter downstream. We might also want to expose mimeType?