Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose presentationTimeOffset on segments that have it #81

Merged
merged 7 commits into from
Mar 26, 2021

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Dec 10, 2019

This doesn't currently update tests' expectations for the change.

* value of the attribute as a string
*
* @return {number}
* The aprsed presentationTimeOffset
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parsed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant what I said >.>

@gkatsev gkatsev self-assigned this Feb 10, 2020
@gkatsev gkatsev changed the base branch from master to main August 7, 2020 18:18
@gkatsev gkatsev force-pushed the presentationTimeOffset branch from 5558bcf to 54ff6fb Compare March 24, 2021 22:44
@brandonocasey brandonocasey merged commit 8b58b39 into main Mar 26, 2021
@gkatsev gkatsev deleted the presentationTimeOffset branch March 26, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants