fix: exit full window mode with Esc key (#7224)

videojs · May 11, 2021 · e9953e5 · e9953e5
1 parent 0e46624
commit e9953e5
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 3 deletions.
diff --git a/src/js/player.js b/src/js/player.js
@@ -2979,9 +2979,11 @@ class Player extends Component {
   fullWindowOnEscKey(event) {
     if (keycode.isEventKey(event, 'Esc')) {
       if (this.isFullscreen() === true) {
-        this.exitFullscreen();
-      } else {
-        this.exitFullWindow();
+        if (!this.isFullWindow) {
+          this.exitFullscreen();
+        } else {
+          this.exitFullWindow();
+        }
       }
     }
   }

diff --git a/test/unit/player-fullscreen.test.js b/test/unit/player-fullscreen.test.js
@@ -207,3 +207,20 @@ QUnit.test('fullscreenOptions from function args should override player options'
 
   player.dispose();
 });
+
+QUnit.test('fullwindow mode should exit when ESC event triggered', function(assert) {
+  const player = FullscreenTestHelpers.makePlayer(true);
+
+  player.enterFullWindow();
+  assert.ok(player.isFullWindow, 'enterFullWindow should be called');
+
+  const evt = TestHelpers.createEvent('keydown');
+
+  evt.keyCode = 27;
+  evt.which = 27;
+  player.boundFullWindowOnEscKey_(evt);
+  // player.fullWindowOnEscKey(evt);
+  assert.equal(player.isFullWindow, false, 'exitFullWindow should be called');
+
+  player.dispose();
+});