-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: live UI button sometimes blinking after click on it. #6201
Conversation
sync with origin branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable to me. In my local testing I didn't really see an improvement, but it definitely wasn't worth and it makes sense that it should be better. Plus, sometimes it's just hard to get it to fail correctly 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like an improvement to me
Description
After clicking on the Live UI control. The button sometimes blinking for a few seconds between Live and non-live mode.
See the gif below:
You can test it on this HLS playlist: http://live-api.miraclechannel.com/hls/miracle1.m3u8?DVR
Specific Changes proposed
Improves calculation algorithm for the
seekableIncrement_
variable.Requirements Checklist