Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: live UI button sometimes blinking after click on it. #6201

Merged
merged 28 commits into from
Aug 28, 2019

Conversation

gjanblaszczyk
Copy link
Member

Description

After clicking on the Live UI control. The button sometimes blinking for a few seconds between Live and non-live mode.
See the gif below:
liveui-bug
You can test it on this HLS playlist: http://live-api.miraclechannel.com/hls/miracle1.m3u8?DVR

Specific Changes proposed

Improves calculation algorithm for the seekableIncrement_ variable.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

gjanblaszczyk and others added 28 commits September 3, 2018 11:07
sync with origin branch
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. In my local testing I didn't really see an improvement, but it definitely wasn't worth and it makes sense that it should be better. Plus, sometimes it's just hard to get it to fail correctly 😆

Copy link
Contributor

@brandonocasey brandonocasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an improvement to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants