Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update being called on seekbar during dispose #6576

Merged
merged 3 commits into from
Apr 13, 2020

Conversation

brandonocasey
Copy link
Contributor

Right now seekBar.update() is getting called on after it is disposed by liveedgechange causing and error to be thrown about player not existing and us trying to call ended on it here

@gkatsev
Copy link
Member

gkatsev commented Apr 9, 2020

Should we also remove the event listeners for other things we are lisetning to like

this.on(this.player_, ['ended', 'durationchange', 'timeupdate'], this.update);
?

@brandonocasey
Copy link
Contributor Author

Yeah let's remove all the event listeners. I am going to open an issue linking back to this pull request. I think we need to investigate why this is happening, and narrow down if it is truly an issue with events or not

@gkatsev
Copy link
Member

gkatsev commented Apr 10, 2020

Is #3097/#6583 the reason all the tests are failing right now?

@brandonocasey
Copy link
Contributor Author

Technically, this pr is a work-around to get it working for now. It appears we need to null check event or pass in an empty object for disableInterval_. I will do that now and the tests should pass.

@gkatsev gkatsev merged commit 3ac11d0 into master Apr 13, 2020
@gkatsev gkatsev deleted the fix/player-dispose-error branch April 13, 2020 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants