Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update 'global' package in dependencies #7213

Merged
merged 1 commit into from
May 3, 2021
Merged

chore: update 'global' package in dependencies #7213

merged 1 commit into from
May 3, 2021

Conversation

vbfox
Copy link
Contributor

@vbfox vbfox commented Apr 29, 2021

Description

Update the global dependency to a recent version. The change already hapenned in http-streaming ( videojs/http-streaming#1031 ) but video.js itself had another dependecy specification. This unifies it.

Specific Changes proposed

  • Bumped the dependency in package.json
  • Ran npm install

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome
Copy link

welcome bot commented Apr 29, 2021

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@gkatsev gkatsev merged commit cb1d29b into videojs:main May 3, 2021
@welcome
Copy link

welcome bot commented May 3, 2021

Congrats on merging your first pull request! 🎉🎉🎉

edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants