Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update player public interface for types visibility #8525

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

dzianis-dashkevich
Copy link
Contributor

Description

seekable, seeking, ended, networkState, readyState are not visible for typescript.

Specific Changes proposed

Move getters declarations directly to the player class.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (6a5e1ee) 83.45% compared to head (a6ad5e2) 82.65%.

Files Patch % Lines
src/js/player.js 46.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8525      +/-   ##
==========================================
- Coverage   83.45%   82.65%   -0.80%     
==========================================
  Files         113      113              
  Lines        7596     7605       +9     
  Branches     1827     1828       +1     
==========================================
- Hits         6339     6286      -53     
- Misses       1257     1319      +62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dzianis-dashkevich dzianis-dashkevich merged commit 1fff5c0 into main Dec 14, 2023
11 of 13 checks passed
@dzianis-dashkevich dzianis-dashkevich deleted the fix-player-types branch December 14, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants