-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: expose version from player.version() #8543
feature: expose version from player.version() #8543
Conversation
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8543 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 113 113
Lines 7612 7614 +2
Branches 1830 1830
=======================================
+ Hits 6296 6298 +2
Misses 1316 1316 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
src/js/player.js
Outdated
* Video.js version | ||
*/ | ||
version() { | ||
return version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think rather than returning just the string, we should return an object with a video.js
property (to match package name) for this version.
This way, we can extend this to add plugin and tech versions in here too, similar to https://github.com/videojs/http-streaming/blob/main/src/videojs-http-streaming.js#L1173-L1180
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed 3b10e8c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks again for your contribution 👍🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Congrats on merging your first pull request! 🎉🎉🎉 |
Description
Expose version from
player.version()
, Issue #8538Specific Changes proposed
Please list the specific changes involved in this pull request.
Requirements Checklist