Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: browser util flagging smart TV as Safari #8566

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Conversation

adrums86
Copy link
Contributor

Description

SmartTV user agent strings were being detected by videojs.browser as Safari.

Specific Changes proposed

Checking the user agent string for Tizen and WebOS then checking for those flags when deducing whether the browser is actually Safari.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fe68e5) 83.44% compared to head (00124c4) 82.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8566      +/-   ##
==========================================
- Coverage   83.44%   82.68%   -0.76%     
==========================================
  Files         113      113              
  Lines        7615     7623       +8     
  Branches     1830     1834       +4     
==========================================
- Hits         6354     6303      -51     
- Misses       1261     1320      +59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrums86 adrums86 merged commit 14b5fde into main Jan 26, 2024
12 of 13 checks passed
@adrums86 adrums86 deleted the fix-smartTV-UA-detection branch January 26, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants