Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert tests from ava to jest #8

Closed
vimark1 opened this issue Oct 26, 2018 · 7 comments
Closed

convert tests from ava to jest #8

vimark1 opened this issue Oct 26, 2018 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@vimark1
Copy link
Owner

vimark1 commented Oct 26, 2018

No description provided.

@vimark1 vimark1 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 26, 2018
@konsvasi
Copy link
Contributor

I'll take a look into it.

@vimark1
Copy link
Owner Author

vimark1 commented Oct 27, 2018

Awesome @konsvasi

@vimark1 vimark1 closed this as completed Oct 27, 2018
@vimark1 vimark1 reopened this Oct 27, 2018
@konsvasi
Copy link
Contributor

Can you take a look at my commit. The tests seem to be passing except the ones that use the require-dir package. During the tests the zombieFunctions has an empty object instead of the functions that are in the folders. I've checked the path and it seems to be correct, I didn't change it.

@vimark1
Copy link
Owner Author

vimark1 commented Oct 27, 2018

Having a look now

@vimark1
Copy link
Owner Author

vimark1 commented Oct 27, 2018

Hey @konsvasi - it seems to be a bug in jest that won't get fixed see aseemk/requireDir#53 - the solution there was to use require-directory. Let me know if that helps. Thanks!

@konsvasi
Copy link
Contributor

Ok, I'll try it, thanks.

@konsvasi konsvasi mentioned this issue Oct 28, 2018
Merged
@vimark1
Copy link
Owner Author

vimark1 commented Oct 28, 2018

Merged in #10

@vimark1 vimark1 closed this as completed Oct 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@konsvasi @vimark1